Support the ongoing development of Laravel.io →
posted 9 years ago
Packages
Last updated 1 year ago.
0

OK , I have found few way to do that after some research .

1 . make post about your package in your blog 2 . try it in some real website and test it 3 . make screen-cast ( installations , demo site )

That way you will get feedback's

0
  • offer a version for L5
0

frezno said:

  • offer a version for L5

Thank you for your feedback , we are working on laravel 5 version

0

Looking through your code, there are some large issues here:

  • You should be using dependency injection inside your classes. You're referencing root classes everywhere inside your package. What if laravel changed the View class name? Your application would break, and you'd need to change it everywhere it's referenced

  • There's no documentation anywhere inside your package code

  • In your service provider, why are you including a command inside the register function: Line 18? Your commands should be binded like so:

$this->app->bind('panel:install', function(){
	return new Serverfireteam\Panel\Commands\PanelCommand();
});
  • Your commands are also using double colon syntax, while the correct syntax is single colon such as:
php artisan cache:clear

Not trying to be mean or anything, just trying to help a fellow developer out!

Last updated 9 years ago.
0

Thank you stevebauman , I will check and fix that

stevebauman said:

Looking through your code, there are some large issues here:

  • You should be using dependency injection inside your classes. You're referencing root classes everywhere inside your package. What if laravel changed the View class name? Your application would break, and you'd need to change it everywhere it's referenced

  • There's no documentation anywhere inside your package code

  • In your service provider, why are you including a command inside the register function: Line 18? Your commands should be binded like so:

$this->app->bind('panel:install', function(){
  return new Serverfireteam\Panel\Commands\PanelCommand();
});
  • Your commands are also using double colon syntax, while the correct syntax is single colon such as:
php artisan cache:clear

Not trying to be mean or anything, just trying to help a fellow developer out!

0

Sign in to participate in this thread!

Eventy

Your banner here too?

serverfire serverfire Joined 13 Nov 2014

Moderators

We'd like to thank these amazing companies for supporting us

Your logo here?

Laravel.io

The Laravel portal for problem solving, knowledge sharing and community building.

© 2024 Laravel.io - All rights reserved.