• offer a version for L5

frezno said:

• offer a version for L5

Thank you for your feedback , we are working on laravel 5 version

Looking through your code, there are some large issues here:

• You should be using dependency injection inside your classes. You're referencing root classes everywhere inside your package. What if laravel changed the View class name? Your application would break, and you'd need to change it everywhere it's referenced

• There's no documentation anywhere inside your package code

• In your service provider, why are you including a command inside the register function: Line 18? Your commands should be binded like so:

$this->app->bind('panel:install', function(){
	return new Serverfireteam\Panel\Commands\PanelCommand();
});

• Your commands are also using double colon syntax, while the correct syntax is single colon such as:

php artisan cache:clear

Not trying to be mean or anything, just trying to help a fellow developer out!

Thank you stevebauman , I will check and fix that

stevebauman said:

Looking through your code, there are some large issues here:

• You should be using dependency injection inside your classes. You're referencing root classes everywhere inside your package. What if laravel changed the View class name? Your application would break, and you'd need to change it everywhere it's referenced

• There's no documentation anywhere inside your package code

• In your service provider, why are you including a command inside the register function: Line 18? Your commands should be binded like so:

$this->app->bind('panel:install', function(){
  return new Serverfireteam\Panel\Commands\PanelCommand();
});

• Your commands are also using double colon syntax, while the correct syntax is single colon such as:

php artisan cache:clear

Not trying to be mean or anything, just trying to help a fellow developer out!